Enhance recipe recalculation algorithm#1723
Merged
christianlupus merged 7 commits intonextcloud:masterfrom Jun 30, 2023
j0hannesr0th:master
Merged
Enhance recipe recalculation algorithm#1723christianlupus merged 7 commits intonextcloud:masterfrom j0hannesr0th:master
christianlupus merged 7 commits intonextcloud:masterfrom
j0hannesr0th:master
Conversation
Signed-off-by: Johannes Roth <git@jrcloud.de>
Signed-off-by: Johannes Roth <git@jrcloud.de>
6 tasks
Signed-off-by: Johannes Roth <git@jrcloud.de>
Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
christianlupus
approved these changes
Jun 30, 2023
Collaborator
christianlupus
left a comment
christianlupus
left a comment
There was a problem hiding this comment.
There are some flaws still in the code but this is yet much better than before.
I unlinked the underlying issue as it is not yet fully satisfied.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Topic and Scope
Fixes at least partially #1603
See it live:
Screencast.from.11.06.2023.23.44.37.webm
Concerns/issues
None
Formal requirements
There are some formal requirements that should be satisfied. Please mark those by checking the corresponding box.